Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report usages from Metrics Server. #2579

Closed
wants to merge 16 commits into from
Closed

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 3, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

See #1066

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #2579 into master will decrease coverage by 0.43%.
The diff coverage is 11.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2579      +/-   ##
==========================================
- Coverage   11.60%   11.17%   -0.44%     
==========================================
  Files          84       85       +1     
  Lines       32932    33028      +96     
==========================================
- Hits         3821     3690     -131     
- Misses      28584    28839     +255     
+ Partials      527      499      -28     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 9.78% <0.00%> (-0.08%) ⬇️
config/config.go 25.00% <0.00%> (-8.34%) ⬇️
...kg/apis/workflow/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
workflow/controller/controller.go 2.21% <0.00%> (-0.22%) ⬇️
pkg/apis/workflow/v1alpha1/generated.pb.go 0.47% <0.83%> (+<0.01%) ⬆️
workflow/controller/operator.go 60.38% <9.09%> (+0.08%) ⬆️
pkg/apis/workflow/v1alpha1/workflow_types.go 12.69% <66.66%> (+1.95%) ⬆️
workflow/controller/usage_moving_avg.go 72.22% <72.22%> (ø)
util/resource/summary.go 83.33% <83.33%> (ø)
util/resource/duration.go 100.00% <100.00%> (+13.88%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc42138...4226c3e. Read the comment docs.

Makefile Outdated
ifeq ($(K3D),true)
k3d import-images $(IMAGE_NAMESPACE)/argocli:$(VERSION)
endif
touch dist/cli-image
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve reliability

docs/argo-server.md Outdated Show resolved Hide resolved
@@ -128,6 +135,8 @@ rules:
resources:
- workflowtemplates
- workflowtemplates/finalizers
- clusterworkflowtemplates
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarabala1979 seem to be missing on master

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge from the latest master. This resource needs to be added as a ClusterRole and ClusterRoleBinding

@alexec alexec added this to the v2.10 milestone Apr 17, 2020
@alexec alexec closed this Apr 20, 2020
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

35.4% 35.4% Coverage
0.0% 0.0% Duplication

@or-shachar
Copy link
Contributor

@alexec - why did we abandon this PR?
I think that exposing actual usage is super valuable in setting right values for requests/limits .

I know this can be done by supporting monitoring tools but having this built-in into argow can ba amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants