-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Report usages from Metrics Server. #2579
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2579 +/- ##
==========================================
- Coverage 11.60% 11.17% -0.44%
==========================================
Files 84 85 +1
Lines 32932 33028 +96
==========================================
- Hits 3821 3690 -131
- Misses 28584 28839 +255
+ Partials 527 499 -28
Continue to review full report at Codecov.
|
Makefile
Outdated
ifeq ($(K3D),true) | ||
k3d import-images $(IMAGE_NAMESPACE)/argocli:$(VERSION) | ||
endif | ||
touch dist/cli-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improve reliability
@@ -128,6 +135,8 @@ rules: | |||
resources: | |||
- workflowtemplates | |||
- workflowtemplates/finalizers | |||
- clusterworkflowtemplates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarabala1979 seem to be missing on master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge from the latest master. This resource needs to be added as a ClusterRole and ClusterRoleBinding
SonarCloud Quality Gate failed. 0 Bugs |
@alexec - why did we abandon this PR? I know this can be done by supporting monitoring tools but having this built-in into argow can ba amazing. |
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.See #1066