Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgraded to Node 14.0.0 #2816

Merged
merged 1 commit into from May 6, 2020
Merged

chore: Upgraded to Node 14.0.0 #2816

merged 1 commit into from May 6, 2020

Conversation

sootysec
Copy link
Contributor

Signed-off-by: Daniel Sutton daniel@ducksecops.uk

Checklist:

  • [ x ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [ x ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [ x] I've signed the CLA.
  • [ x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ x] My builds are green. Try syncing with master if they are not.
  • [ x] My organization is added to USERS.md.

Signed-off-by: Daniel Sutton <daniel@ducksecops.uk>
@sonarcloud
Copy link

sonarcloud bot commented Apr 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexec
Copy link
Contributor

alexec commented Apr 25, 2020

Can I please ask why are the benefits?

@alexec alexec self-assigned this Apr 25, 2020
@sootysec
Copy link
Contributor Author

Hi Alex

The previous node version 11 in the dockerfile was end of life of 1st June 2019. Upgrading to 14 takes it to April 2023.

Cheers,

Daniel

@alexec
Copy link
Contributor

alexec commented May 6, 2020

We should update this.

@alexec alexec merged commit 5f01c4a into argoproj:master May 6, 2020
alexec pushed a commit to alexec/argo-workflows that referenced this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants