New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Nodes with pods deleted out-of-band should be Errored, not Failed #2855
Changes from all commits
1fd6118
e09ea73
3e2b27f
22e25da
855319b
2ba1bd7
0a260c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -957,8 +957,8 @@ func (woc *wfOperationCtx) assessNodeStatus(pod *apiv1.Pod, node *wfv1.NodeStatu | |
case apiv1.PodRunning: | ||
if pod.DeletionTimestamp != nil { | ||
// pod is being terminated | ||
newPhase = wfv1.NodeFailed | ||
message = "pod termination" | ||
newPhase = wfv1.NodeError | ||
message = "pod deleted during operation" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this needs to be reverted as well since you will be reverting the logic of deletion of running pods.. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is unrelated. This makes sure that Nodes that have pods deleted out-of-band get marked as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's simply a node label change |
||
} else { | ||
newPhase = wfv1.NodeRunning | ||
tmplStr, ok := pod.Annotations[common.AnnotationKeyTemplate] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular code fixes #2914