Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Tolerate deleted workflow when running argo delete. Fixes #2821 #2877

Merged
merged 21 commits into from Apr 30, 2020
Merged

feat(cli): Tolerate deleted workflow when running argo delete. Fixes #2821 #2877

merged 21 commits into from Apr 30, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 29, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Changes

  • build: Preemptively pull build images.
  • build: Run cron tests in own job.
  • build: Remove dep as it was not needed.
  • build: Tried to make make swagger more robust.
  • fix: Removed unused proto message parameter 'createOptions'.
  • feat: Tolerate deleted workflow when running argo delete.
  • test: Enforce whitelisted images earlier.

@alexec alexec changed the title ci: Run cron in own suite. feat(cli): Tolerate deleted workflow when running argo delete. Apr 29, 2020
@alexec alexec linked an issue Apr 29, 2020 that may be closed by this pull request
Argo delete all/completed should not abort on missing Workflow #2821
Closed
@alexec alexec changed the title feat(cli): Tolerate deleted workflow when running argo delete. feat(cli): Tolerate deleted workflow when running argo delete. Fixes #2821 Apr 29, 2020
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@alexec alexec marked this pull request as ready for review April 29, 2020 23:18
@alexec alexec requested a review from jessesuen as a code owner April 29, 2020 23:18
simster7
simster7 approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp

Makefile
api/openapi-spec/swagger.json: $(HOME)/go/bin/swagger pkg/apiclient/_.secondary.swagger.json $(SWAGGER_FILES) $(MANIFESTS_VERSION_FILE) hack/swaggify.sh
$(SWAGGER_FILES): pkg/apiclient/_.secondary.swagger.json proto

api/openapi-spec/swagger.json: $(HOME)/go/bin/swagger $(SWAGGER_FILES) $(MANIFESTS_VERSION_FILE) hack/swaggify.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix #2892?

@alexec alexec merged commit 9e4ac9b into argoproj:master Apr 30, 2020
@alexec alexec deleted the ci-cron branch April 30, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Argo delete all/completed should not abort on missing Workflow
2 participants
@alexec @simster7