fix(cli): Test workflow retry with and without persistence. Fixes #2850 #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markterm
changed the title
markterm
changed the title
markterm
force-pushed
the
test-workflow-retry-with-and-without-persistence
branch
from
f3d2cfc
to
7b67438
Compare
simster7
reviewed
May 1, 2020
|
|
||
| func WorkflowRetryCommon(s fixtures.E2ESuite) { |
There was a problem hiding this comment.
Should we be putting all these in a cli_common.go file?
There was a problem hiding this comment.
I don't like this. E2ESuite is an abstract base class and we shouldn't be passing it around like a normal variable.
There was a problem hiding this comment.
I think the cli_common.go is a good idea. @alexec do you have an alternate idea how to structure these common tests?
markterm
force-pushed
the
test-workflow-retry-with-and-without-persistence
branch
2 times, most recently
from
f5c1672
to
c16dc5d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This PR looks stale? |
|
Yes, I think made moot by #2941 - I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".