docs: Document node field selector. Closes #2860 #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
suggested changes
Apr 29, 2020
|
|
||
| ## Introduction | ||
|
|
||
| If triggering an external job (eg an Amazon EMR job) from Argo that does not run to completion in a container, there are two options: |
alexec
reviewed
Apr 29, 2020
| @@ -43,7 +43,7 @@ message WorkflowResubmitRequest { | |||
| message WorkflowRetryRequest { | |||
| string name = 1; | |||
| string namespace = 2; | |||
| bool restartSuccesful = 3; | |||
There was a problem hiding this comment.
Is this a breaking change? Has this gone GA yet?
There was a problem hiding this comment.
It is breaking, but it's part of v2.8 and hasn't gone GA yet.
alexec
reviewed
Apr 29, 2020
docs/node-field-selector.md
Outdated
| @@ -0,0 +1,42 @@ | |||
| # Node Field Selectors | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
I think this should be alpha or beta.
alexec
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
@jessesuen could you please rubber-stamp the proto changes? This needs to be back-ported for v2.8.0-rc4
simster7
approved these changes
Apr 29, 2020
|
@simster7 done |
markterm
force-pushed
the
docs-node-field-selector
branch
from
c5dc0e4
to
6864828
Compare
|
Please run |
|
@alexec lint issue should be fixed |
Co-Authored-By: Simon Behar <simbeh7@gmail.com>
Co-Authored-By: Simon Behar <simbeh7@gmail.com>
Co-Authored-By: Simon Behar <simbeh7@gmail.com>
Co-Authored-By: Simon Behar <simbeh7@gmail.com>
Co-Authored-By: Simon Behar <simbeh7@gmail.com>
markterm
force-pushed
the
docs-node-field-selector
branch
from
f06d6fc
to
a342f36
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".