Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ConfigMap syntax #2889

Merged
merged 1 commit into from Apr 29, 2020
Merged

fix: ConfigMap syntax #2889

merged 1 commit into from Apr 29, 2020

Conversation

rguichard
Copy link
Contributor

@rguichard rguichard commented Apr 29, 2020 •
edited

Fix broken code introduced with #2872

Also update each ConfigMap examples

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@rguichard
fix: ConfigMap syntax
bf3be47 
Update each ConfigMap example
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@alexec
Copy link
Contributor

alexec commented Apr 29, 2020

@ntwrkguru could you please review?

@alexec alexec linked an issue Apr 29, 2020 that may be closed by this pull request
workflow-controller should throw an error when config has 'config' and any other key #2885
Closed
@ntwrkguru
Copy link
Contributor

LGTM

@alexec alexec merged commit a0035dd into argoproj:master Apr 29, 2020
@rguichard rguichard deleted the patch branch April 29, 2020 16:11
@rguichard rguichard restored the patch branch April 29, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@ntwrkguru ntwrkguru ntwrkguru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workflow-controller should throw an error when config has 'config' and any other key
4 participants
@rguichard @CLAassistant @alexec @ntwrkguru