fix(swagger)!: Fixes invalid K8S definitions in swagger.json. Fixes #2888

[alexec]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed the CLA.
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

This is a breaking change:

• Why? The swagger is wrong and unusable in certain circumstances.
• Who? Only users generating code from swagger.json. Probably not you then.
• Migration: Re-generate your code.

Fixes #2888

[alexec]

@cburbridge could you please review this PR?

[cburbridge]

I have tested the generated swagger file to submit workflows containing volume mounts, artifacts, secret keys selectors etc, and it seems to be just fine to me. I have generated workflow specs based on the above fixed swagger, and in parallel based on the old broken swagger but with the kubernetes definitions manually replaced by correct kubernetes ones. Both cases now produce the exact same spec, and the spec works when submitted.

[cburbridge]

Thanks!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[simster7]

Rubber-stamp