Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use argoproj/argosay:v1 #2917

Merged
merged 5 commits into from May 1, 2020
Merged

test: Use argoproj/argosay:v1 #2917

merged 5 commits into from May 1, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 1, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Changes

This PR will make the E2E suites faster and more reliable, both locally and on CI, by allowing ups to pull the image from Docker Hub.

Skips TestStopBehaviour - see #2833

@alexec alexec requested a review from simster7 May 1, 2020 15:57
@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexec alexec marked this pull request as ready for review May 1, 2020 16:24
@alexec alexec marked this pull request as ready for review May 1, 2020 16:48
@alexec alexec merged commit 1c45d5e into argoproj:master May 1, 2020
@alexec alexec deleted the test-argosay branch May 1, 2020 16:50
alexec added a commit to alexec/argo-workflows that referenced this pull request May 1, 2020
@alexec
test: Use argoproj/argosay:v1 (argoproj#2917)
7bf922e
alexec added a commit that referenced this pull request May 5, 2020
@alexec
test: Use argoproj/argosay:v1 (#2917)
0f7f9c4
@agilgur5 agilgur5 mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexec @simster7