Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Remove the excessive logging of node data #2925

Merged
merged 4 commits into from May 1, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 1, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec
Copy link
Contributor Author

alexec commented May 1, 2020

@jessesuen @sarabala1979 could you think of any reason these log statements log the whole node? Did it used to have String(). None of these statements are structured or really greppable, so I don't think changing them will be a problem.

@alexec alexec marked this pull request as ready for review May 1, 2020 17:58
@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

76.9% 76.9% Coverage
0.0% 0.0% Duplication

@alexec alexec merged commit 99858ea into argoproj:master May 1, 2020
@alexec alexec deleted the feat-reduce-logging branch May 1, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants