Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Mockery #3000

Merged
merged 1 commit into from May 11, 2020
Merged

chore: Update Mockery #3000

merged 1 commit into from May 11, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented May 11, 2020 •
edited

mockery was updated to v1.1.0. In this version, when using mockery from go get it prints a v0.0.0-dev version instead of v1.0.0. Since the CI uses the go get version, update as needed.

Local version of mockery will also need to be updated. Simply run

$ rm ~/go/bin/mockery
$ rm ~/go/src/github.com/vektra/mockery
$ go get github.com/vektra/mockery
$ make mocks

@simster7 simster7 requested a review from alexec May 11, 2020 17:29
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@simster7 simster7 merged commit 47472f7 into argoproj:master May 11, 2020
alexec pushed a commit to alexec/argo-workflows that referenced this pull request May 11, 2020
@simster7 @alexec
chore: Update Mockery (argoproj#3000)
e08fdb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simster7 @alexec