Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Mockery v1.1.1 #3015

Merged
merged 5 commits into from May 12, 2020
Merged

build: Mockery v1.1.1 #3015

merged 5 commits into from May 12, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 12, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec marked this pull request as ready for review May 12, 2020 20:20
@alexec alexec requested a review from simster7 May 12, 2020 20:20
simster7
simster7 reviewed May 12, 2020
View reviewed changes
Makefile
tar zxvf dist/mockery.tar.gz mockery
chmod +x mockery
mkdir -p $(GOPATH)/bin
mv mockery $(GOPATH)/bin/mockery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Manually overwriting binaries in go/bin might break some existing users' flow with go get. The download is 2 MB... perhaps we should keep in in the dist folder?

  2. What happens if the file already exists?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the file already exists, nothing happens, we want to install it permanently, we could go back to go get?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason to install permanently = reliability + speed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the file already exists, nothing happens

This is good enough, then. IMO

Makefile Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexec alexec merged commit b516098 into argoproj:master May 12, 2020
@alexec alexec deleted the build-mockery branch May 12, 2020 20:49
alexec added a commit to alexec/argo-workflows that referenced this pull request May 12, 2020
@alexec
build: Mockery v1.1.1 (argoproj#3015)
3716591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexec @simster7