refactor: Refactor assesDAGPhase logic #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
commented
May 14, 2020
This was referenced May 26, 2020
simster7
changed the title
This reverts commit 0cd816b.
|
Kudos, SonarCloud Quality Gate passed!
|
jessesuen
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2975
Fixes #3096
Fixes #3104
This is a WIP: it is not ready for review.
Currently when assessing DAG pahses
hasMoreRetriesis used to determine if a node has more retries available. This is independent ofprocessNodeRetries, which is the source of truth as to whether a node has more retries.This has created issues where a DAG might think a node has more retries when it in fact does not, deadlocking the controller: #2975, #2966, #2656, #3096
This attempts to solve this issue by using
processNodeRetriesdirectly to assess a DAG phase.