Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update container delete grace period to match Kubernetes default #3064

Merged
merged 4 commits into from Jun 2, 2020

Conversation

matveybrant
Copy link
Contributor

@matveybrant matveybrant commented May 20, 2020

Per https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#pod-v1-core the default pod grace period is 30 seconds, so I believe this should match per the comment.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Per https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#pod-v1-core the default pod grace period is 30 seconds, so I believe this should match per the comment.
@simster7 simster7 self-assigned this May 21, 2020
@simster7
Copy link
Member

I doubt we'll want to change this number as a whole. We'll probably want to parametrize this.

@matveybrant
Copy link
Contributor Author

I agree that we should parameterize it, but in the mean time I thought it would make sense to at least set it to match the kubernetes default

@simster7
Copy link
Member

@jessesuen had also mentioned he expected this value to be 30 seconds. I'll bring it up with him

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants