Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run only condition is satisfied #3082

Closed
wants to merge 1 commit into from

Conversation

sh-tatsuno
Copy link
Contributor

Checklist:

  • this is a bug fix
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". running onExit handler in dag task even if condition isn't match #3081
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alexec alexec self-assigned this May 22, 2020
// The onExit node is either not complete or has errored out, return.
return
}
if proceed {
// Run the node's onExit node, if any.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff - any thoughts on how to automated testing of this change?

@simster7
Copy link
Member

Hi @sh-tatsuno, thank you for opening this PR! I didn't realize that you would attempt to fix this, so I opened #3083 to fix this issue.

Since said PR has the preferred and complete fix, I'll be closing this issue in favor of it.

@simster7 simster7 closed this May 22, 2020
@sh-tatsuno
Copy link
Contributor Author

@simster7 OK, sorry for confusing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants