Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix TestContinueOnFailDag. Closes #2624 #3101

Merged
merged 1 commit into from May 25, 2020
Merged

test: fix TestContinueOnFailDag. Closes #2624 #3101

merged 1 commit into from May 25, 2020

Conversation

vmanucharyan
Copy link
Contributor

@vmanucharyan vmanucharyan commented May 25, 2020 •
edited by alexec

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Closes #2624

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexec alexec changed the title test: fix TestContinueOnFailDag Closes #2624 test: fix TestContinueOnFailDag. Closes #2624 May 25, 2020
alexec
alexec approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LTGM

@alexec alexec merged commit e4e0dfb into argoproj:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TestContinueOnFailDag
2 participants
@vmanucharyan @alexec