Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Display error message instead of DAG when DAG cannot be rendered. Fixes #3091 #3125

Merged
merged 1 commit into from May 28, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 28, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #3091

Changes

  • Add a panel that shows the error instead of the loading animation if the DAG cannot be loaded.
  • Tidy up the summary panel:
    • Colorise phase
    • Show relative start and finish time.

Screenshots

workflow-summary

workflow-panel

@alexec alexec requested a review from simster7 May 28, 2020 19:07
@alexec alexec marked this pull request as ready for review May 28, 2020 19:07
@alexec alexec merged commit 0909214 into argoproj:master May 28, 2020
@alexec alexec deleted the fix-empty-dag branch May 28, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the UI, if the workflow could not start, we should show why - not sit there loading the DAG
2 participants