Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(item): Support ItemValue.Type == List. Fixes #2660 #3129

Merged
merged 5 commits into from May 28, 2020
Merged

fix(item): Support ItemValue.Type == List. Fixes #2660 #3129

merged 5 commits into from May 28, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 28, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #2660

Should back-port to v2.8

@alexec alexec requested a review from sarabala1979 May 28, 2020 22:45
alexec
alexec commented May 28, 2020
View reviewed changes
pkg/apis/workflow/v1alpha1/item.go
@@ -170,7 +183,9 @@ func (iv ItemValue) MarshalJSON() ([]byte, error) {
return json.Marshal(iv.NumVal)
case Map:
return json.Marshal(iv.MapVal)
case List:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the actual fix - this branch was missing

@alexec alexec marked this pull request as ready for review May 28, 2020 22:51
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@alexec alexec merged commit 1814ea2 into argoproj:master May 28, 2020
@alexec alexec deleted the fix-2660 branch May 28, 2020 23:16
alexec added a commit that referenced this pull request May 28, 2020
@alexec
fix(item): Support ItemValue.Type == List. Fixes #2660 (#3129)
05dd786 
* fix(item): Support ItemValue.Type == List. Fixes #2660

* fix(item): Support ItemValue.Type == List. Fixes #2660

* fix-2660

* fix-2660

* fix-2660
@alexec alexec mentioned this pull request Jun 24, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@sarabala1979 sarabala1979 Awaiting requested review from sarabala1979

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue passing List of Objects from script
2 participants
@alexec @simster7