Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Report controller error counters via metrics. Closes #3034 #3144

Merged
merged 3 commits into from Jun 3, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Jun 2, 2020

Closes: #3034

Currently only supports:

  • Operation panics
  • CronWorkflow submission errors

This interface should only be used for errors that are impossible to surface with custom metrics

@simster7 simster7 marked this pull request as ready for review June 2, 2020 19:26
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@simster7 simster7 requested a review from alexec June 3, 2020 16:48
@alexec alexec changed the title feat: Report controller error counters via metrics feat(metrics): Report controller error counters via metrics. Closes #3034 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics should display controller error counts by type
2 participants