Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add instructions on using Minikube as an alternative to K3D #3162

Merged
merged 2 commits into from Jun 3, 2020
Merged

docs: Add instructions on using Minikube as an alternative to K3D #3162

merged 2 commits into from Jun 3, 2020

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Jun 3, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

simster7
simster7 reviewed Jun 3, 2020
View reviewed changes
docs/running-locally.md Outdated

Useful:

* For a PS1 prompt showing your current kube context: kube-ps1 to help. `brew install kube-ps1`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why this is needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in the doc before and I just moved it around. I am not sure why it's necessary either. Should I just delete it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpler is better - > please delete

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexec
Copy link
Contributor

alexec commented Jun 3, 2020

LGTM

@alexec alexec merged commit e36fe66 into argoproj:master Jun 3, 2020
@terrytangyuan terrytangyuan deleted the patch-1 branch June 3, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 left review comments

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terrytangyuan @alexec @simster7