fix(server): Allow field selection for workflow-event endpoint (fixes #3163) #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abel in the new labels column
… to take up less real estate.
…ait from labels column
…mponent to keep track of show/hide state. Reformat column widths for readability and change format of labels
…ces duration, and conditions
simster7
reviewed
Jun 5, 2020
go.mod
Outdated
| @@ -29,7 +29,7 @@ require ( | |||
| github.com/go-openapi/swag v0.19.8 // indirect | |||
| github.com/go-sql-driver/mysql v1.4.1 | |||
| github.com/gogo/protobuf v1.3.1 | |||
| github.com/golang/protobuf v1.4.0 | |||
| github.com/golang/protobuf v1.3.5 | |||
There was a problem hiding this comment.
I think the changes to go.mod and go.sum were unintentional. Could you revert them back by doing git checkout master go.mod go.sum?
| @@ -89,6 +89,7 @@ message WorkflowDeleteResponse { | |||
| message WatchWorkflowsRequest { | |||
| string namespace = 1; | |||
| k8s.io.apimachinery.pkg.apis.meta.v1.ListOptions listOptions = 2; | |||
| string fields = 3; | |||
There was a problem hiding this comment.
Where is this field actually used? I don't see it in the Argo Server code
There was a problem hiding this comment.
In fact I don't see it used anywhere in List either: https://github.com/rbreeze/argo/blob/162f49559cb4a24eadccb20129b8ce04fb36faca/server/workflow/workflow_server.go#L94
Seems like that was the bug?
|
Kudos, SonarCloud Quality Gate passed!
|
simster7
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".