Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Change "DB=..." to "PROFILE=..." #3216

Merged
merged 6 commits into from Jun 11, 2020
Merged

build: Change "DB=..." to "PROFILE=..." #3216

merged 6 commits into from Jun 11, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 11, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec marked this pull request as ready for review June 11, 2020 18:12
@alexec alexec requested a review from simster7 June 11, 2020 18:12
@alexec alexec mentioned this pull request Jun 11, 2020
Merged
6 tasks
simster7
simster7 approved these changes Jun 11, 2020
View reviewed changes
manifests/quick-start-minimal.yaml
Comment on lines -5 to -6
labels:
app.kubernetes.io/part-of: argo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexec alexec merged commit a37d0a7 into argoproj:master Jun 11, 2020
@alexec alexec deleted the build-profile branch June 11, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexec @simster7