Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Correctly update workflow list when workflow are modified/deleted #3220

Merged
merged 4 commits into from Jun 12, 2020
Merged

fix(ui): Correctly update workflow list when workflow are modified/deleted #3220

merged 4 commits into from Jun 12, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 11, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec added this to the v2.9 milestone Jun 11, 2020
@alexec alexec requested review from rbreeze and simster7 June 11, 2020 19:51
@alexec alexec marked this pull request as ready for review June 11, 2020 19:53
@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@alexec alexec linked an issue Jun 11, 2020 that may be closed by this pull request
Workflows do not disappear from workflow list in UI when deleted #3208
Closed
rbreeze
rbreeze reviewed Jun 11, 2020
View reviewed changes
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this Alex! Looks great to me

@alexec alexec merged commit 3460859 into argoproj:master Jun 12, 2020
@alexec alexec deleted the fix-list branch June 12, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze left review comments

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.

Workflows do not disappear from workflow list in UI when deleted
3 participants
@alexec @simster7 @rbreeze