Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Migrate to Github Actions #3233

Merged
merged 50 commits into from Jun 16, 2020
Merged

build: Migrate to Github Actions #3233

merged 50 commits into from Jun 16, 2020

Conversation

simster7
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@simster7 simster7 marked this pull request as ready for review June 16, 2020 18:49
@simster7 simster7 requested a review from alexec June 16, 2020 18:49
@simster7
Copy link
Member Author

@alexec Ready for an initial review. Will need to disable the required old Circle checks once ready.

@simster7 simster7 changed the title build: Migrate to Github Actions (POC) build: Migrate to Github Actions Jun 16, 2020
alexec
alexec reviewed Jun 16, 2020
View reviewed changes
.github/workflows/ci-build.yaml Outdated
strategy:
fail-fast: false
matrix:
test: ["smoke", "test", "test-e2e", "test-e2e-cron"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I think we can lose smoke if we have test-e2e

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed smoke

@alexec
Copy link
Contributor

alexec commented Jun 16, 2020

Looks good so far. Proof is in the pudding.

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@simster7 simster7 merged commit c25e288 into argoproj:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simster7 @alexec