Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): Fixes Git when using auth or fetch. Fixes #2343 #3248

Merged
merged 5 commits into from Jun 23, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 17, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #2343
See #3246

Changes

  • Write SSH private key to a temp file rather than ~/.ssh/id_rsa so we don't delete my keys while testing 😡
  • Add support for authentication when used with fetch or revision.

@alexec alexec changed the title fix(git): Fixes Git when using auth or fetch. Fixes #2343 and #3246 fix(git): Fixes Git when using auth or fetch. Fixes #2343 Jun 17, 2020
@alexec alexec requested a review from sarabala1979 June 17, 2020 19:18
@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@alexec alexec marked this pull request as ready for review June 17, 2020 20:18
workflow/artifacts/git/git.go Show resolved Hide resolved
workflow/artifacts/git/git.go Outdated Show resolved Hide resolved
@sarabala1979 sarabala1979 self-assigned this Jun 23, 2020
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git artifact fetch of reference fails due to missing credentials
3 participants