Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Update workflow drawer with new duration format #3256

Merged
merged 2 commits into from Jun 22, 2020

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jun 18, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@rbreeze rbreeze requested a review from alexec June 18, 2020 22:36
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I please request you add screenshots?

@rbreeze
Copy link
Member Author

rbreeze commented Jun 18, 2020

@alexec of course!
Screen Shot 2020-06-18 at 4 06 41 PM
Screen Shot 2020-06-18 at 4 07 09 PM
Screen Shot 2020-06-18 at 4 07 51 PM
Screen Shot 2020-06-18 at 4 08 29 PM

@alexec
Copy link
Contributor

alexec commented Jun 19, 2020

good work - can I ask you to make the workflow details version consistent with this new style?

@rbreeze
Copy link
Member Author

rbreeze commented Jun 19, 2020

definitely - should we potentially have more significant figures in the details view, since presumably the user might want more info there? or is 1 sigfig enough in all use cases?

@rbreeze
Copy link
Member Author

rbreeze commented Jun 19, 2020

Also, by new format do you mean purely the sigfig change, or do you also mean changing the workflow details view to have to rows rather than inline?

@alexec
Copy link
Contributor

alexec commented Jun 19, 2020

@rbreeze I just mean when the resource durations are formatted. I think this would just be the case of editing just line 14 of resources-duration.tsx to use the same formatting

@rbreeze
Copy link
Member Author

rbreeze commented Jun 19, 2020

@alexec perfect, changed

@rbreeze rbreeze merged commit c7e4c18 into argoproj:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants