Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mysql yaml port #3258

Merged
merged 1 commit into from Jun 19, 2020
Merged

chore: update mysql yaml port #3258

merged 1 commit into from Jun 19, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jun 19, 2020

Signed-off-by: yeya24 yb532204897@gmail.com

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2020

CLA assistant check
All committers have signed the CLA.

@yeya24 yeya24 changed the title Update mysql yaml port chore: update mysql yaml port Jun 19, 2020
@@ -555,7 +555,7 @@ spec:
image: mysql:8
name: main
ports:
- containerPort: 5432
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is very wrong! - but I think it must be changed in a different file - mysql-deployment.yaml and then run make manifests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL!

Signed-off-by: yeya24 <yb532204897@gmail.com>
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 boom!

@alexec
Copy link
Contributor

alexec commented Jun 19, 2020

Sorry - you need to to sign CLA before merge.

@yeya24
Copy link
Contributor Author

yeya24 commented Jun 19, 2020

Sorry - you need to to sign CLA before merge.

Done

@alexec alexec merged commit 54dd72c into argoproj:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants