feat: Append previous workflow name as label to resubmitted workflow #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
suggested changes
Jun 20, 2020
workflow/util/util.go
Outdated
| const letters = "abcdefghijklmnopqrstuvwxyz0123456789" | ||
| const ( | ||
| letters = "abcdefghijklmnopqrstuvwxyz0123456789" | ||
| previousWorkflowNameLabelKey = "workflows.argoproj.io/previous-workflow-name" |
There was a problem hiding this comment.
This should be added in https://github.com/argoproj/argo/blob/master/workflow/common/common.go
Also I would suggest this be called
Suggested change
| previousWorkflowNameLabelKey = "workflows.argoproj.io/previous-workflow-name" | |
| previousWorkflowNameLabelKey = "workflows.argoproj.io/resubmitted-from-workflow" |
Comment on lines
+499
to
+501
| if newWF.ObjectMeta.Labels == nil { | ||
| newWF.ObjectMeta.Labels = make(map[string]string) | ||
| } |
There was a problem hiding this comment.
Huh, wonder why this didn't come up as an issue before
workflow/util/util.go
Outdated
| newWF.ObjectMeta.Labels[key] = val | ||
| } | ||
| // Append an additional label so it's easy for user to see the | ||
| // name of the original workflow that has been resubmitted. | ||
| newWF.ObjectMeta.Labels[previousWorkflowNameLabelKey] = wf.ObjectMeta.Name |
|
@simster7 Thanks for the review! Just updated the PR to address your comments. |
simster7
approved these changes
Jun 20, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append an additional label so it's easy for user to see the name of the original workflow that has been resubmitted.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".