Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix delete --complete #3278

Merged
merged 3 commits into from Jun 23, 2020
Merged

fix: Fix delete --complete #3278

merged 3 commits into from Jun 23, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 23, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec requested a review from simster7 June 23, 2020 16:55
alexec
alexec commented Jun 23, 2020
View reviewed changes
server/workflow/workflow_server.go
@@ -391,7 +391,7 @@ func (s *workflowServer) getWorkflow(wfClient versioned.Interface, namespace str
if err != nil {
return nil, err
}
log.Infof("Resolved alias %s to workflow %s.\n", latestAlias, latest.Name)
log.Debugf("Resolved alias %s to workflow %s.\n", latestAlias, latest.Name)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor - bug logs in the CLI

@alexec alexec marked this pull request as ready for review June 23, 2020 18:13
sarabala1979
sarabala1979 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@sarabala1979 sarabala1979 self-assigned this Jun 23, 2020
@alexec alexec merged commit 62e54fb into argoproj:master Jun 23, 2020
@alexec alexec deleted the fix-delete branch June 23, 2020 22:45
alexec added a commit that referenced this pull request Jun 25, 2020
@alexec
fix: Fix delete --complete (#3278)
a91cea5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

@simster7 simster7 Awaiting requested review from simster7

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexec @sarabala1979