Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller)!: Support nested items. Fixes #3288 #3290

Merged
merged 5 commits into from
Jun 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -2510,7 +2510,7 @@
},
"io.argoproj.workflow.v1alpha1.Item": {
"description": "Item expands a single workflow step into multiple parallel steps The value of Item can be a map, string, bool, or number",
"type": "string",
"type": "object",
"format": "item"
},
"io.argoproj.workflow.v1alpha1.Link": {
Expand Down
14 changes: 0 additions & 14 deletions pkg/apis/api-rules/violation_exceptions.list
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,HDFSConfig,Addresses
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Histogram,Buckets
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Inputs,Parameters
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Item,ListVal
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,ItemValue,ListVal
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Metrics,Prometheus
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,NodeStatus,Children
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,NodeStatus,OutboundNodes
Expand All @@ -32,18 +30,6 @@ API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,WorkflowSpec,Volumes
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,WorkflowStatus,PersistentVolumeClaims
API rule violation: list_type_missing,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,WorkflowStep,WithItems
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Item,BoolVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Item,ListVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Item,MapVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Item,NumVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Item,StrVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,Item,Type
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,ItemValue,BoolVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,ItemValue,ListVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,ItemValue,MapVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,ItemValue,NumVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,ItemValue,StrVal
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,ItemValue,Type
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,ParallelSteps,Steps
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,SubmitOpts,Entrypoint
API rule violation: names_match,github.com/argoproj/argo/pkg/apis/workflow/v1alpha1,WorkflowStatus,StoredWorkflowSpec