New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to change priority when resubmitting workflows #3293
Conversation
if cmd.Flag("priority").Changed { | ||
cliSubmitOpts.priority = &priority | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this here if we use priority *int32
instead of priority int32
. Take a look at commands/submit.go
.
Can you refactor this to match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just updated.
Something seems wrong in the build as it’s stuck in “wait for Argo Server to be ready”. Any clues @simster7? |
Are you able to run |
@simster7 I had to revert my last change so the argo server can start successfully. It was actually already following the same behavior as in Edit: codegen build failure is unrelated and is also happening on master branch. |
This bug that broke your build is fixed on master - you'll need to sync with master to get green and merged. |
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@alexec Thanks. Just rebased and it's green now. |
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.