Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to change priority when resubmitting workflows #3293

Merged
merged 2 commits into from Jun 26, 2020
Merged

feat: Allow to change priority when resubmitting workflows #3293

merged 2 commits into from Jun 26, 2020

Conversation

terrytangyuan
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Comment on lines +28 to +43
if cmd.Flag("priority").Changed {
cliSubmitOpts.priority = &priority
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this here if we use priority *int32 instead of priority int32. Take a look at commands/submit.go.

Can you refactor this to match?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just updated.

@terrytangyuan
Copy link
Member Author

Something seems wrong in the build as it’s stuck in “wait for Argo Server to be ready”. Any clues @simster7?

@simster7
Copy link
Member

Are you able to run make start locally?

@terrytangyuan
Copy link
Member Author

terrytangyuan commented Jun 25, 2020

@simster7 I had to revert my last change so the argo server can start successfully. It was actually already following the same behavior as in commands/submit.go. Did I miss anything?

Edit: codegen build failure is unrelated and is also happening on master branch.

@alexec
Copy link
Contributor

alexec commented Jun 25, 2020

This bug that broke your build is fixed on master - you'll need to sync with master to get green and merged.

@terrytangyuan
Copy link
Member Author

@alexec Thanks. Just rebased and it's green now.

@simster7 simster7 merged commit b5ed90f into argoproj:master Jun 26, 2020
@terrytangyuan terrytangyuan deleted the priority-resubmit branch June 26, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants