Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Add support for Docker workflow executor for Windows nodes #3301

Merged
merged 5 commits into from Jul 9, 2020
Merged

feat(controller): Add support for Docker workflow executor for Windows nodes #3301

merged 5 commits into from Jul 9, 2020

Conversation

lippertmarkus
Copy link
Member

@lippertmarkus lippertmarkus commented Jun 25, 2020

Argoexec already works with Windows Containers but didn't support docker workflow executor yet as Windows Containers require a different way of mounting the Docker socket (see kubernetes/kubernetes#69484):

  • Path: \\.\pipe\docker_engine
  • Type: null
  • ReadOnly: false

I adapted the workflow controller to allow for different volume setups for Windows or Linux Steps of a workflow. When the following nodeSelector entry is present for a step in a workflow, then the volume setup for Windows is used, else the setup for Linux is used:

nodeSelector:
  kubernetes.io/os: windows

I also adapted the documentation as you not longer need to use the kubelet workflow executor.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
    • not needed
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec self-assigned this Jun 25, 2020
@alexec alexec added this to the v2.10 milestone Jun 25, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. I've got just one comment and you'll need to fix conflicts so we can merge. Great work!

workflow/controller/workflowpod.go Outdated Show resolved Hide resolved
…r-executor

# Conflicts:
#	workflow/controller/workflowpod_test.go
@lippertmarkus lippertmarkus requested a review from alexec July 8, 2020 05:37
@lippertmarkus
Copy link
Member Author

lippertmarkus commented Jul 9, 2020

Thanks for reviewing, I fixed all conflicts and the naming of the function now.

@alexec alexec merged commit 05b3590 into argoproj:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants