Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove CircleCI #3302

Merged
merged 1 commit into from Jun 25, 2020
Merged

ci: Remove CircleCI #3302

merged 1 commit into from Jun 25, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 25, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec marked this pull request as ready for review June 25, 2020 15:53
@alexec alexec requested a review from simster7 June 25, 2020 15:53
@alexec
Copy link
Contributor Author

alexec commented Jun 25, 2020

Merge as soon as approved.

@simster7
Copy link
Member

@alexec I think you might have to remove Circle from the repository in some other way. The reason I kept the dummy job was because even if the CI config file was removed, it would still expect something to run

@alexec
Copy link
Contributor Author

alexec commented Jun 25, 2020

I've deleted us from CircleCI via their settings page so it will stop complaining now and this PR will be OK.

@alexec alexec merged commit 436c125 into argoproj:master Jun 25, 2020
@alexec alexec deleted the rm-cic branch June 25, 2020 18:06
alexec added a commit that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants