fix: Use a unique queue to visit nodes #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarabala1979
reviewed
Jul 8, 2020
sarabala1979
reviewed
Jul 8, 2020
alexec
reviewed
Jul 8, 2020
workflow/controller/dag.go
Outdated
| @@ -127,6 +127,42 @@ func generatePhaseNodes(children []string, branchPhase wfv1.NodePhase) []phaseNo | |||
| return out | |||
| } | |||
|
|
|||
| type uniqueQueue struct { | |||
There was a problem hiding this comment.
Working on it as we speak
alexec
reviewed
Jul 8, 2020
| // If a phaseNode has already existed, it will not be added silently | ||
| func (uq *uniquePhaseNodeQueue) add(nodes ...phaseNode) { | ||
| for _, node := range nodes { | ||
| key := fmt.Sprintf("%s-%s", node.nodeId, node.phase) |
There was a problem hiding this comment.
Quick explanation: if an omitted node is reached first from a step that succeeded, we consider the omitted node succeeded. However, it may be subsequently reached from another step that did not succeed. In that case we want to update the deduced status of the omitted node, and we may only do so by adding it to the queue.
There was a problem hiding this comment.
(I added this explanation as a comment as well)
alexec
reviewed
Jul 8, 2020
workflow/controller/phase_node.go
Outdated
| } | ||
|
|
||
| func (uq *uniquePhaseNodeQueue) pop() phaseNode { | ||
| var toPop phaseNode |
alexec
approved these changes
Jul 8, 2020
simster7
added a commit
that referenced
this pull request
Jul 8, 2020
4 tasks
4 tasks
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.