Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): panic on wait command if event is null #3424

Merged
merged 1 commit into from Jul 8, 2020
Merged

fix(cli): panic on wait command if event is null #3424

merged 1 commit into from Jul 8, 2020

Conversation

sarabala1979
Copy link
Member

@sarabala1979 sarabala1979 commented Jul 8, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". Panic on CLI Watch command  #3422
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec changed the title fix: anic on wait command if event is null fix(cli): panic on wait command if event is null Jul 8, 2020
alexec
alexec reviewed Jul 8, 2020
View reviewed changes
cmd/argo/commands/wait.go
}
errors.CheckError(err)
if event == nil {
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is event nil?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an extra check based on stack trace event is nil for panic. Based on code, if re-establishment happens, an event may be nil.

alexec
alexec approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back port to v2.9?

@sarabala1979
Copy link
Member Author

sure

@sarabala1979 sarabala1979 merged commit 330d4a0 into argoproj:master Jul 8, 2020
sarabala1979 added a commit that referenced this pull request Jul 8, 2020
@sarabala1979
fix: panic on wait command if event is null (#3424)
1e736b2
@sarabala1979
Copy link
Member Author

The fix has been backported to 2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sarabala1979 @alexec