Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): Label workflows with creator. Closes #2437 #3440

Merged
merged 11 commits into from Jul 15, 2020
Merged

feat(server): Label workflows with creator. Closes #2437 #3440

merged 11 commits into from Jul 15, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jul 9, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Closes #2437

This is intended to pave the way for webhooks.

Screenshot 2020-07-14 at 19 03 21

creator

@alexec alexec requested review from sarabala1979 and removed request for sarabala1979 July 10, 2020 17:29
alexec
alexec commented Jul 14, 2020
View reviewed changes
server/auth/jwt/jwt_test.go Outdated Show resolved Hide resolved
alexec
alexec commented Jul 14, 2020
View reviewed changes
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
alexec
alexec commented Jul 14, 2020
View reviewed changes
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
alexec
alexec commented Jul 14, 2020
View reviewed changes
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
alexec
alexec commented Jul 14, 2020
View reviewed changes
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
alexec
alexec commented Jul 14, 2020
View reviewed changes
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
alexec
alexec commented Jul 14, 2020
View reviewed changes
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
alexec
alexec commented Jul 14, 2020
View reviewed changes
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
@alexec alexec marked this pull request as ready for review July 14, 2020 20:58
@alexec alexec requested a review from jessesuen as a code owner July 14, 2020 20:58
@alexec
Copy link
Contributor Author

alexec commented Jul 14, 2020 •
edited

@jessesuen this is ready for review now having made the change. I'm aware I need to write a few a lot of unit tests.

alexec
alexec commented Jul 14, 2020
View reviewed changes
server/workflowtemplate/workflow_template_server.go
@@ -29,6 +30,7 @@ func (wts *WorkflowTemplateServer) CreateWorkflowTemplate(ctx context.Context, r
return nil, fmt.Errorf("workflow template was not found in the request body")
}
wts.instanceIDService.Label(req.Template)
creator.Label(ctx, req.Template)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test

alexec
alexec commented Jul 14, 2020
View reviewed changes
server/workflowtemplate/workflow_template_server.go
@@ -88,6 +90,7 @@ func (wts *WorkflowTemplateServer) DeleteWorkflowTemplate(ctx context.Context, r
func (wts *WorkflowTemplateServer) LintWorkflowTemplate(ctx context.Context, req *workflowtemplatepkg.WorkflowTemplateLintRequest) (*v1alpha1.WorkflowTemplate, error) {
wfClient := auth.GetWfClient(ctx)
wts.instanceIDService.Label(req.Template)
creator.Label(ctx, req.Template)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test

@alexec alexec merged commit acf56f9 into argoproj:master Jul 15, 2020
@alexec alexec deleted the creator branch July 15, 2020 02:30
@toyamagu-2021 toyamagu-2021 mentioned this pull request May 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search for workflows by creator
2 participants
@alexec @jessesuen