Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(controller): Add memoization tests. See #3214 (#3455) #3466

Merged
merged 2 commits into from Jul 13, 2020
Merged

test(controller): Add memoization tests. See #3214 (#3455) #3466

merged 2 commits into from Jul 13, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jul 13, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

See #3214 (#3455)

@alexec
Copy link
Contributor Author

alexec commented Jul 13, 2020

My test was actually wrong.

@alexec alexec requested a review from simster7 July 13, 2020 20:47
@alexec alexec merged commit 847ba53 into argoproj:master Jul 13, 2020
@alexec alexec deleted the test-3455 branch July 13, 2020 21:06
alexec added a commit that referenced this pull request Jul 13, 2020
@alexec
test(controller): Add memoization tests. See #3214 (#3455) (#3466)
065d9b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

@simster7 simster7 Awaiting requested review from simster7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexec @sarabala1979