fix(controller): Fail workflow when pod is deleted with --force. Fixes #3097 #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Jul 14, 2020
| oldPod, newPod := old.(*apiv1.Pod), new.(*apiv1.Pod) | ||
| if oldPod.ResourceVersion == newPod.ResourceVersion { | ||
| return | ||
| } | ||
| if !pod.SignificantPodChange(oldPod, newPod) { | ||
| log.WithField("key", key).Info("insignificant pod change") |
There was a problem hiding this comment.
I want to be more aware when we ignore changes.
|
This should be back-ported to v2.9 |
alexec
added
type/bug
type/regression
sarabala1979
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Fixes #3097
This is actually not the original problem in #3097, instead introduced by
SignificantPodChange, but only whenkubectl delete --force pod ...is used. The informer treats this delete as a update rather than a delete. @jessesuen @alexmt informer weirdness you might want to be aware of.