build: Simplify builds #3478
Merged
build: Simplify builds #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've re-enabled up-to-date with master check. |
alexec
changed the title
alexec
commented
Jul 15, 2020
| mkdir -p /tmp/log/argo-e2e | ||
| KUBECONFIG=~/.kube/config make start PROFILE=$PROFILE E2E_EXECUTOR=docker DEV_IMAGE=true > /tmp/log/argo-e2e/argo.log & | ||
| git fetch --tags |
alexec
commented
Jul 15, 2020
| mkdir -p /tmp/log/argo-e2e | ||
| KUBECONFIG=~/.kube/config make start PROFILE=$PROFILE E2E_EXECUTOR=docker DEV_IMAGE=true > /tmp/log/argo-e2e/argo.log & | ||
| git fetch --tags | ||
| KUBECONFIG=~/.kube/config make start PROFILE=$PROFILE E2E_EXECUTOR=docker DEV_IMAGE=true 2>&1 > /tmp/log/argo-e2e/argo.log & |
alexec
commented
Jul 15, 2020
| @@ -102,14 +99,10 @@ jobs: | |||
| codegen: | |||
| name: Codegen | |||
| runs-on: ubuntu-latest | |||
| timeout-minutes: 10 | |||
| timeout-minutes: 15 | |||
There was a problem hiding this comment.
occasionally this takes longer than 10m
alexec
commented
Jul 15, 2020
| @@ -21,10 +21,6 @@ jobs: | |||
| steps: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v2 | |||
| with: | |||
There was a problem hiding this comment.
@simster7 thoughts on this change?
There was a problem hiding this comment.
All good with me as long as it plays nice with GIT_BRANCH = $(shell git branch --show-current), which was the original reason for the code being this way
alexec
commented
Jul 15, 2020
| @@ -1,4 +1,4 @@ | |||
| # Resume The Template | |||
| # Resume A Workflow | |||
alexec
commented
Jul 15, 2020
alexec
commented
Jul 15, 2020
alexec
changed the title
simster7
approved these changes
Jul 15, 2020
| @@ -21,10 +21,6 @@ jobs: | |||
| steps: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v2 | |||
| with: | |||
There was a problem hiding this comment.
All good with me as long as it plays nice with GIT_BRANCH = $(shell git branch --show-current), which was the original reason for the code being this way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".@simster7 @sarabala1979 I've been spending too much time fixing builds recently and want to simplify them.
This change will mean that we no longer build branch images (i.e. no images name
argoproj/argocli:my-branchinstead, they will be latest. You must runmake cleanwhenever you change branch to get new images.