fix(cli): Check mutual exclusivity for argo CLI flags

[terrytangyuan]

This sets the right expectations to users. --resubmitted can be used jointly while --completed and --running are mutually exclusive.

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed the CLA.
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[simster7]

Could I ask that you also go over the rest of the flags and commands and do all mutex checks that are applicable?

[terrytangyuan]

@simster7 Absolutely. I'll include all changes in this PR.

[terrytangyuan]

@simster7 Just went over and there doesn't seem to be many of them left. I updated the PR with the ones I found. The build failure is unrelated.

[alexec]

Can you please investigate failing tests?

[terrytangyuan]

I am seeing the following error that's unrelated to this PR. It also happens in other PRs as well, e.g. #3488.

##[error]level=info msg=... condition="to finish" message="OCI runtime create failed: container_linux.go:349: starting container process caused \"exec: \\\"sh\\\": executable file not found in $PATH\": unknown" phase=Failed timeout=30s type=MODIFIED workflow=exit-1

[alexec]

The failing test is:

    --- FAIL: TestCLISuite/TestWorkflowDeleteAll (3.98s)
        cli_test.go:395: 
            	Error Trace:	cli_test.go:395
            	            				given.go:179
            	            				cli_test.go:394
            	Error:      	Received unexpected error:
            	            	exit status 1
            	Test:       	TestCLISuite/TestWorkflowDeleteAll

Tip: search for FAIL: in the logs.

Could this be related to this PR?

[terrytangyuan]

@alexec Thanks! That's good tip. It's fixed now.

[alexec]

this can't be correct - all workflows created by e2e test must get this label - so this probably means there is a bug

[terrytangyuan]

Could you clarify where is incorrect? There is only one workflow called basic at this point so deleting all would just means only this workflow gets deleted.

[alexec]

All test workflows must be annotated with argo-e2e - if it fails to delete, then it indicates that --all is not deleting all workflows labelled with argo-e2e. --all should work with -l, but does not appear to.

[terrytangyuan]

Okay I see. I've reverted the flag check in delete command. Please take another look.