Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Bash Completions for More Resources #3494

Merged
merged 4 commits into from Jul 16, 2020
Merged

feat: Support Bash Completions for More Resources #3494

merged 4 commits into from Jul 16, 2020

Conversation

dtaniwaki
Copy link
Member

@dtaniwaki dtaniwaki commented Jul 16, 2020 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

I added more bash completions so we can easily use WorkflowTemplate, ClusterWorkflowTemplate, and CronWorkflow.

@dtaniwaki dtaniwaki changed the title Support Bash Completions of More Resources feat: Support Bash Completions for More Resources Jul 16, 2020
@alexec
Copy link
Contributor

alexec commented Jul 16, 2020

@dtaniwaki I thought we could generate this file?

@dtaniwaki
Copy link
Member Author

dtaniwaki commented Jul 16, 2020 •
edited

Oh, really? I don't know how to do that for resource names.

simster7
simster7 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! Thanks @dtaniwaki

@alexec
Copy link
Contributor

alexec commented Jul 16, 2020

https://www.bookstack.cn/read/cobra/bash_completions.md would it be worthwhile going 10x on this?

@dtaniwaki
Copy link
Member Author

@alexec I think that works for subcommands, but not for resource names.

@alexec alexec merged commit 27528ba into argoproj:master Jul 16, 2020
@dtaniwaki dtaniwaki deleted the improve-completion branch July 17, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtaniwaki @alexec @simster7