Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(artifacts): support optional input artifacts, Fixes #3491 #3512

Merged
merged 8 commits into from Jul 21, 2020
Merged

fix(artifacts): support optional input artifacts, Fixes #3491 #3512

merged 8 commits into from Jul 21, 2020

Conversation

haibingzhao
Copy link
Contributor

@haibingzhao haibingzhao commented Jul 18, 2020 •
edited by simster7

Closes: #3491

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@haibingzhao haibingzhao mentioned this pull request Jul 18, 2020
Closed
@simster7 simster7 self-assigned this Jul 20, 2020
simster7
simster7 reviewed Jul 20, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add a test please?

@haibingzhao
Copy link
Contributor Author

Looks good, could you add a test please?

Ok, test is ready now.

simster7
simster7 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@simster7 simster7 merged commit 31afa92 into argoproj:master Jul 21, 2020
alexec pushed a commit that referenced this pull request Jul 28, 2020
@haibingzhao @alexec
fix(artifacts): support optional input artifacts, Fixes #3491 (#3512)
d2bd587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees

@simster7 simster7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support optional Input artifacts when artifacts not exist
3 participants
@haibingzhao @CLAassistant @simster7