Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: String interpreted as boolean in labels #3518

Merged
merged 1 commit into from Jul 19, 2020

Conversation

jonnylangefeld
Copy link
Contributor

Running this without quotes results in the following error:

error: unable to decode "https://raw.githubusercontent.com/argoproj/argo/master/examples/hello-world.yaml": resource.metadataOnlyObject.ObjectMeta: v1.ObjectMeta.Labels: ReadString: expects " or n, but found f, error found in #10 byte of ...|trategy":false}},"sp|..., bigger context ...|abels":{"workflows.argoproj.io/archive-strategy":false}},"spec":{"entrypoint":"whalesay","templates"|...

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Running this without quotes results in the following error:
```
error: unable to decode "https://raw.githubusercontent.com/argoproj/argo/master/examples/hello-world.yaml": resource.metadataOnlyObject.ObjectMeta: v1.ObjectMeta.Labels: ReadString: expects " or n, but found f, error found in argoproj#10 byte of ...|trategy":false}},"sp|..., bigger context ...|abels":{"workflows.argoproj.io/archive-strategy":false}},"spec":{"entrypoint":"whalesay","templates"|...
```
@alexec alexec merged commit 49ef5c0 into argoproj:master Jul 19, 2020
@jonnylangefeld jonnylangefeld deleted the patch-1 branch July 20, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants