ci: Make builds marginally faster. Fixes #3515 #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Jul 19, 2020
| GIT_TREE_STATE = $(shell if [ -z "`git status --porcelain`" ]; then echo "clean" ; else echo "dirty"; fi) | ||
|
|
||
| export DOCKER_BUILDKIT = 1 | ||
|
|
||
| # To allow you to build with or without cache for debugging purposes. | ||
| DOCKER_BUILD_OPTS := --no-cache |
There was a problem hiding this comment.
no longer needed, all builds are done an Github Actions - we should always cache
alexec
commented
Jul 19, 2020
|
|
||
| .PHONY: publish-release | ||
| publish-release: check-version-warning build | ||
| # Push images to Docker Hub | ||
| docker push $(IMAGE_NAMESPACE)/argocli:$(VERSION) |
There was a problem hiding this comment.
we never push locally for releases
alexec
commented
Jul 19, 2020
| @@ -36,29 +36,6 @@ const Label = "argo-e2e" | |||
| // Cron tests run in parallel, so use a different label so they are not deleted when a new test runs | |||
| const LabelCron = Label + "-cron" | |||
|
|
|||
| var imageTag string | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
unreliable code removed in v2.9
alexec
changed the title
sarabala1979
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Improvements
There are some slow tests, but no single test which is much worse that other tests. So no improvement to be made there today.
Fixes #3515