New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix links in fields doc #3539
Conversation
@@ -1,3 +1,5 @@ | |||
// +build !fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file imports "github.com/argoproj/argo/cmd/argo/commands"
, so it will in effect build the entire codebase into the binary. This takes a lot of time and it will require generating static files, which takes even longer. Since this is unnecessary for the script in this PR, don't include this file when we're building for this purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this. Can I ask we just fix the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #3529