Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip TestStorageQuotaLimit #3566

Merged
merged 2 commits into from Jul 23, 2020
Merged

fix: Skip TestStorageQuotaLimit #3566

merged 2 commits into from Jul 23, 2020

Conversation

sarabala1979
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

sarabala1979
sarabala1979 commented Jul 23, 2020
View reviewed changes
test/e2e/functional_test.go
@@ -641,6 +641,9 @@ spec:
}

func (s *FunctionalSuite) TestStorageQuotaLimit() {
// TODO Test fails due to unstable PVC creation and termination in K3S
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PVC creation and termination are failing inconsistently in k3s. I am investigating in another PR. Skipping this test currently.

alexec
alexec approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptive approval.

@sarabala1979 sarabala1979 marked this pull request as ready for review July 23, 2020 15:26
@sarabala1979 sarabala1979 merged commit 827106d into argoproj:master Jul 23, 2020
alexec pushed a commit that referenced this pull request Jul 23, 2020
@sarabala1979 @alexec
fix: Skip TestStorageQuotaLimit (#3566)
a366648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sarabala1979 @alexec