Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix multiple UI issues #3573

Merged
merged 6 commits into from Jul 24, 2020
Merged

fix(ui): Fix multiple UI issues #3573

merged 6 commits into from Jul 24, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Jul 23, 2020

Fixes #3570

This PR fixes:

  • Issue with buttons being improperly hidden in "Workflow DAG" view (e.g. "Stop" is hidden when Workflow is running)
  • Issue with actions not correctly redirecting after they are performed
  • Issue with toolbar buttons being improperly hidden
  • Issue when performing a batch action Workflows remain selected

@alexec alexec self-assigned this Jul 23, 2020
@alexec alexec changed the title fix: Fix multiple UI issues fix(ui): Fix multiple UI issues Jul 23, 2020
iconClassName: string;
disabled: (wf: Workflow) => boolean;
}

export const WorkflowOperations = {
export type WorkflowOperationAction = (wf: Workflow) => Promise<any>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could use just Operation or Action as they are synonyms

@simster7 simster7 merged commit 8b6e43f into argoproj:master Jul 24, 2020
alexec pushed a commit that referenced this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Workflow details UI toolbar
2 participants