Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Argo Workflows does not honour global timeout if step/pod is not able to schedule #3581

Merged
merged 12 commits into from Jul 27, 2020
Merged

fix: Argo Workflows does not honour global timeout if step/pod is not able to schedule #3581

merged 12 commits into from Jul 27, 2020

Conversation

sarabala1979
Copy link
Member

@sarabala1979 sarabala1979 commented Jul 24, 2020 •
edited

Checklist:

@sarabala1979 sarabala1979 requested a review from alexec July 24, 2020 05:56
simster7
simster7 suggested changes Jul 24, 2020
View reviewed changes
workflow/controller/workflowpod.go Outdated Show resolved Hide resolved
@sarabala1979 sarabala1979 mentioned this pull request Jul 26, 2020
Closed
simster7
simster7 approved these changes Jul 27, 2020
View reviewed changes
workflow/controller/operator.go Outdated Show resolved Hide resolved
@sarabala1979 sarabala1979 merged commit 491f4f7 into argoproj:master Jul 27, 2020
alexec pushed a commit that referenced this pull request Jul 28, 2020
@sarabala1979 @alexec
fix: Argo Workflows does not honour global timeout if step/pod is not…
35a0049 
… able to schedule (#3581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@alexec alexec Awaiting requested review from alexec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Argo Workflows does not honour global timeout if step/pod is not able to schedule
2 participants
@sarabala1979 @simster7