Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Fix bug in util/RecoverWorkflowNameFromSelectorString. Add error handling #3596

Merged
merged 2 commits into from Jul 25, 2020

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jul 24, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@rbreeze rbreeze requested a review from alexec July 25, 2020 00:15
@rbreeze rbreeze merged commit 17b46bd into argoproj:master Jul 25, 2020
alexec pushed a commit that referenced this pull request Jul 28, 2020
simster7 pushed a commit that referenced this pull request Aug 6, 2020
@alexec
Copy link
Contributor

alexec commented Aug 6, 2020

Available in v2.9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants