Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Treat TooManyError same as Forbidden (i.e. try again). Fixes #3606 #3607

Merged
merged 2 commits into from Jul 28, 2020
Merged

fix(controller): Treat TooManyError same as Forbidden (i.e. try again). Fixes #3606 #3607

merged 2 commits into from Jul 28, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jul 27, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #3606

@alexec alexec marked this pull request as ready for review July 27, 2020 16:51
@sarabala1979
Copy link
Member

sarabala1979 commented Jul 27, 2020 •
edited

Fixes #3600

@simster7 simster7 self-assigned this Jul 27, 2020
@alexec alexec assigned sarabala1979 and unassigned simster7 Jul 27, 2020
@alexec alexec added this to In progress in 2019-07-28 via automation Jul 27, 2020
2019-07-28 automation moved this from In progress to Reviewer approved Jul 28, 2020
@alexec alexec merged commit 86f03a3 into argoproj:master Jul 28, 2020
2019-07-28 automation moved this from Reviewer approved to Done Jul 28, 2020
@alexec alexec deleted the fix-3606 branch July 28, 2020 17:05
alexec added a commit that referenced this pull request Aug 11, 2020
@alexec
fix(controller): Treat TooManyError same as Forbidden (i.e. try again).
e12d26e 
Fixes #3606 (#3607)
@alexec
Copy link
Contributor Author

alexec commented Aug 14, 2020

Available in v2.10.0-rc7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
No open projects
2019-07-28
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry on the server has received too many requests and has asked us to try again later (post pods) errors
3 participants
@alexec @sarabala1979 @simster7